Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCodeEditor] Enable exiting with esc for all modes #3833

Merged
merged 3 commits into from
Jul 30, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jul 30, 2020

Summary

Fixes #3819, which highlighted an un-exit-able EuiCodeEditor when enableLiveAutocompletion=true.

The problem stemmed from the this.aceEditor.editor.completer logic, which will always be present when enableLiveAutocompletion=true regardless of the actual presence of an autocomplete element. There is no other analog to discern a scenario where esc is hit and an autocomplete is open.

The solution is the use the react-ace commands interface, which does not execute when an autocomplete is open. The previous onAceKeydown logic remains because commands also do no execute in read-only mode.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation

  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl requested a review from myasonik July 30, 2020 17:57
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3833/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3833/

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thompsongl thompsongl merged commit f847070 into elastic:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EUICodeEditor doesn't prevent focus trap via hint overlay if you've made edits
4 participants